Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bam t #53

Merged
merged 17 commits into from
Aug 18, 2023
Merged

Bam t #53

merged 17 commits into from
Aug 18, 2023

Conversation

masarunakajima
Copy link
Member

@masarunakajima masarunakajima commented Aug 18, 2023

  • Modified BamReader::read_entry to use bam1_t directly instead of converting it to string.
  • Fixed the problem of ending quality score parsing two bases short for bam files.
  • Created mechanism to skip quality score parsing if no quality scores are given, for sam and bam files
  • Made a function to make sure the vectors in tile_position_quality and tile_position_count all have length of maximum read length. This is needed for sam and bam files because the lengths of these vectors remain 0 if quality score parsing is skipped by the above mechanism.
  • Made separate cases for bam and sam in get_tile_split_position

@guilhermesena1 guilhermesena1 merged commit 20b2a85 into master Aug 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants