Undo the disable of source maps for non-chrome browsers #9941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCMicS
approved these changes
Mar 19, 2024
niloc132
reviewed
Mar 19, 2024
There was a problem hiding this comment.
Worth testing if this is what was breaking #9759 - since this claims that only chrome/safari support sourcemaps (clearly untrue, hasn't been true for a very long time), this might prevent the symbolmaplinker from correctly producing output when collapsed?
Nowadays, all modern browsers support sourcemaps by default, so there is no need to have exception configuration anymore.
vegegoku
force-pushed
the
undo-disable-source-maps-for-non-chrome-browsers-test
branch
from
71128f7
to
7668bbe
Compare
niloc132
reviewed
Apr 24, 2024
Nowadays, all modern browsers support sourcemaps by default, so there is no need to have exception configuration anymore. Fixes: gwtproject#9759
vegegoku
force-pushed
the
undo-disable-source-maps-for-non-chrome-browsers-test
branch
from
7668bbe
to
bec5b3e
Compare
niloc132
approved these changes
Apr 26, 2024
|
Update description to list any issues fixed by this, and summarize changes, then we can merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowadays, all modern browsers support sourcemaps by default, so there is no need to have exception configuration anymore.