Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo the disable of source maps for non-chrome browsers #9941

Merged
merged 2 commits into from
May 11, 2024
Merged

Undo the disable of source maps for non-chrome browsers #9941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f17695
Undo the disable of source maps for non-chrome browsers
vegegoku Mar 19, 2024
bec5b3e
Undo the disable of source maps for non-chrome browsers
vegegoku Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 0 additions & 16 deletions user/src/com/google/gwt/core/CoreWithUserAgent.gwt.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,4 @@
<!-- Deferred binding rules for core classes based on user agent. -->
<module>
<inherits name="com.google.gwt.core.Core"/>

<!-- Disable source maps for non-Chrome browsers -->
<!-- TODO(goktug): enable source maps for non-Chrome browsers -->
<set-property name="compiler.useSourceMaps" value="false">
<none>
<when-property-is name="user.agent" value="safari"/>
</none>
</set-property>

<replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorModern">
<when-type-is class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />
<when-property-is name="compiler.stackMode" value="native" />
<when-property-is name="user.agent" value="safari" />
<when-property-is name="compiler.useSourceMaps" value="true"/>
</replace-with>

</module>
7 changes: 6 additions & 1 deletion user/src/com/google/gwt/core/StackTrace.gwt.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,14 @@
<when-property-is name="compiler.stackMode" value="native" />
</replace-with>


<replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorNull">
<when-type-is class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />
<when-property-is name="compiler.stackMode" value="strip" />
</replace-with>

<replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorModern">
<when-type-is class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />
<when-property-is name="compiler.stackMode" value="native" />
<when-property-is name="compiler.useSourceMaps" value="true"/>
</replace-with>
</module>
5 changes: 1 addition & 4 deletions user/test/com/google/gwt/user/LoggingRPCSuite.gwt.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,9 @@
</set-property>

<!-- when stack trace stripping is enabled, we need to replace the Null collector
with one that does something for Chrome -->
with one that does something -->
<replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorChrome">
<when-type-is class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />
<!-- For now, only Chrome provides Error.stack support, so we hijack the
entire WebKit permutation -->
<when-property-is name="user.agent" value="safari" />
<when-property-is name="compiler.useSourceMaps" value="true" />
</replace-with>

Expand Down