Skip to content

Commit

Permalink
Undo the disable of source maps for non-chrome browsers (#9941)
Browse files Browse the repository at this point in the history
Nowadays, all modern browsers support sourcemaps by default, so there is
no need to have exception configuration anymore.

Fixes #9759
  • Loading branch information
vegegoku committed May 11, 2024
1 parent 9be7196 commit 468bf52
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 21 deletions.
16 changes: 0 additions & 16 deletions user/src/com/google/gwt/core/CoreWithUserAgent.gwt.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,4 @@
<!-- Deferred binding rules for core classes based on user agent. -->
<module>
<inherits name="com.google.gwt.core.Core"/>

<!-- Disable source maps for non-Chrome browsers -->
<!-- TODO(goktug): enable source maps for non-Chrome browsers -->
<set-property name="compiler.useSourceMaps" value="false">
<none>
<when-property-is name="user.agent" value="safari"/>
</none>
</set-property>

<replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorModern">
<when-type-is class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />
<when-property-is name="compiler.stackMode" value="native" />
<when-property-is name="user.agent" value="safari" />
<when-property-is name="compiler.useSourceMaps" value="true"/>
</replace-with>

</module>
7 changes: 6 additions & 1 deletion user/src/com/google/gwt/core/StackTrace.gwt.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,14 @@
<when-property-is name="compiler.stackMode" value="native" />
</replace-with>


<replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorNull">
<when-type-is class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />
<when-property-is name="compiler.stackMode" value="strip" />
</replace-with>

<replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorModern">
<when-type-is class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />
<when-property-is name="compiler.stackMode" value="native" />
<when-property-is name="compiler.useSourceMaps" value="true"/>
</replace-with>
</module>
5 changes: 1 addition & 4 deletions user/test/com/google/gwt/user/LoggingRPCSuite.gwt.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,9 @@
</set-property>

<!-- when stack trace stripping is enabled, we need to replace the Null collector
with one that does something for Chrome -->
with one that does something -->
<replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorChrome">
<when-type-is class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />
<!-- For now, only Chrome provides Error.stack support, so we hijack the
entire WebKit permutation -->
<when-property-is name="user.agent" value="safari" />
<when-property-is name="compiler.useSourceMaps" value="true" />
</replace-with>

Expand Down

0 comments on commit 468bf52

Please sign in to comment.