Undo the disable of source maps for non-chrome browsers

Nowadays, all modern browsers support sourcemaps by default, so there is no need to have exception configuration anymore. Fixes: #9759
gwtproject · Apr 25, 2024 · bec5b3e · bec5b3e
1 parent 9f17695
commit bec5b3e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 13 deletions.
diff --git a/user/src/com/google/gwt/core/CoreWithUserAgent.gwt.xml b/user/src/com/google/gwt/core/CoreWithUserAgent.gwt.xml
@@ -15,12 +15,4 @@
 <!-- Deferred binding rules for core classes based on user agent. -->
 <module>
   <inherits name="com.google.gwt.core.Core"/>
-
-  <replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorModern">
-    <when-type-is class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />
-    <when-property-is name="compiler.stackMode" value="native" />
-    <when-property-is name="user.agent" value="safari" />
-    <when-property-is name="compiler.useSourceMaps" value="true"/>
-  </replace-with>
-
 </module>
diff --git a/user/src/com/google/gwt/core/StackTrace.gwt.xml b/user/src/com/google/gwt/core/StackTrace.gwt.xml
@@ -45,9 +45,14 @@
     <when-property-is name="compiler.stackMode" value="native" />
   </replace-with>
 
-
   <replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorNull">
     <when-type-is class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />
     <when-property-is name="compiler.stackMode" value="strip" />
   </replace-with>
+
+  <replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorModern">
+    <when-type-is class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />
+    <when-property-is name="compiler.stackMode" value="native" />
+    <when-property-is name="compiler.useSourceMaps" value="true"/>
+  </replace-with>
 </module>
diff --git a/user/test/com/google/gwt/user/LoggingRPCSuite.gwt.xml b/user/test/com/google/gwt/user/LoggingRPCSuite.gwt.xml
@@ -30,12 +30,9 @@
   </set-property>
 
   <!-- when stack trace stripping is enabled, we need to replace the Null collector 
-       with one that does something for Chrome -->
+       with one that does something -->
   <replace-with class="com.google.gwt.core.client.impl.StackTraceCreator.CollectorChrome">
     <when-type-is class="com.google.gwt.core.client.impl.StackTraceCreator.Collector" />
-    <!-- For now, only Chrome provides Error.stack support, so we hijack the
-         entire WebKit permutation -->
-    <when-property-is name="user.agent" value="safari" />
     <when-property-is name="compiler.useSourceMaps" value="true" />
   </replace-with>