BF: show start parameter for stop only eyetracker components #6456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the Stop Only action type causes experiments to crash. This is because the stop recording component never has its status set to START in the compiled python code. It does make sense to have a Start time because in theory you might want to Stop following a stimulus or something like that. This edit means that the stop recording component is set to start and therefore the recording is stopped.
|
I'm not sure about "Stop only" having a start time exposed to the user - it would be better to change the boilerplate so that its status is set regardless of start time if type is "Stop only". What's the use case in which listening for a stop needs a custom start rather than just the beginning of the Routine? If you wanted to stop it when a stimulus finishes, surely you'd just use stimName.status == FINISHED in the value for "Stop" and "conditional" for "Stop type"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Stop Only action type causes experiments to crash. This is because the stop recording component never has its status set to START in the compiled python code. It does make sense to have a Start time because in theory you might want to Stop following a stimulus or something like that. This edit means that the stop recording component is set to start and therefore the recording is stopped.