BF: fix an issue with etRecord component for Stop Only #6460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug with the etRecord component in builder because the constructor for
psychopy.hardware.eyetracker.EyetrackerControl
always initializes the_status
attribute asNOT_STARTED
. This causes an issue when the component is used under the "Stop Only" Record actions. In this scenario, two independent etRecord components are initialized, causing the bug, because the experiment can only change the status of the second component (supposed to stop recording) toFINISHED
if the status is alreadySTARTED
.Instead, the status of any
EyetrackerControl
instance should reflect whether recording is currently enabled for the tracker instance passed into the constructor. Looking throughpsychopy.iohub.devices.eyetracker.hw
,isRecordingEnabled()
is appropriately defined for everyone so this fix should work seamlessly.