ENH: Improvements to start/stop behaviour of Eyetracker Record Components #6457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix the problem identified in #6456
The problem:
.status = STARTED
.status = STARTED
calls a property/setter pair which actually starts the eyetracker, this is generally inadvisable as sometimes we want to just tell Builder it's started (i.e. when there's a new Component but not a new device, we want to mark the Component asSTARTED
but don't want to start the device again)The solution(s):
.status = STARTED
starting the eyetracker, have the start code in a function calledstartRecording
and call this function explicitly in the Builder code (ditto for stopping the recording)status
returns to being just an attribute for tracking progress in Builder.status = STARTED
at the very beginning (which we can now do safely)Bonus: