Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove another .view_layouts #13410

Merged
merged 1 commit into from
May 19, 2024
Merged

Remove another .view_layouts #13410

merged 1 commit into from
May 19, 2024

Conversation

IceSentry
Copy link
Contributor

I forgot to save that file when submitting #13394 馃槄

@IceSentry IceSentry added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy X-Uncontroversial This work is generally agreed upon labels May 17, 2024
@IceSentry IceSentry requested a review from pcwalton May 17, 2024 07:14
jgayfer
jgayfer approved these changes May 18, 2024
View reviewed changes
Copy link
Contributor

@jgayfer jgayfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with the full context here, but follows the same pattern as the mentioned PR 馃憤

@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 19, 2024
@mockersf mockersf added this pull request to the merge queue May 19, 2024
Merged via the queue into bevyengine:main with commit bf2aced May 19, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@jgayfer jgayfer jgayfer approved these changes

@pcwalton pcwalton Awaiting requested review from pcwalton

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IceSentry @mockersf @jgayfer