-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix normals computation for gltf #13396
fix normals computation for gltf #13396
Conversation
@adithramachandran can I get your review here? |
Technically the current behaviour is the 0.13 behaviour. Are those examples new since 0.13? I'm still not a huge fan of normals not being computed the same based on the vertex layout without any warnings to the user, but I guess that's not a big issue. |
|
Oh, I know what's going on. In 0.13 it was just always calling duplicate_meshes and it was removed in the PR that computed smooth normals inside compute_flat_normals. I feel like it would be better to use that instead of now not always computing flat normals. |
Objective
custom_gltf_vertex_attribute
orgltf_skinned_mesh
Solution
compute_flat_normals
orcompute_smooth_normals
as appropriateTesting