Emissive is now LinearRgba on StandardMaterial #13352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andristarr
force-pushed
the
standardmaterial.linearrgba
branch
from
67cd64c
to
b92f7fd
Compare
alice-i-cecile
approved these changes
May 13, 2024
alice-i-cecile
added
A-Rendering
andristarr
force-pushed
the
standardmaterial.linearrgba
branch
2 times, most recently
from
7fde0d9
to
3bbf3bd
Compare
andristarr
force-pushed
the
standardmaterial.linearrgba
branch
from
3bbf3bd
to
04dd81a
Compare
|
Just need to change the wording around the emissive so its not confusing |
andristarr
force-pushed
the
standardmaterial.linearrgba
branch
2 times, most recently
from
ca4fd0b
to
6ef0701
Compare
|
This should be ready for review @alice-i-cecile |
tychedelia
reviewed
May 14, 2024
tychedelia
reviewed
May 14, 2024
tychedelia
reviewed
May 14, 2024
alice-i-cecile
added
the
S-Waiting-on-Author
|
Sorry, i was on vacation and will get to this soon! |
|
Thanks for letting us know :) I hope you had a lovely vacation! |
andristarr
force-pushed
the
standardmaterial.linearrgba
branch
from
ea3526f
to
c77b5d6
Compare
alice-i-cecile
added
S-Needs-Review
andristarr
force-pushed
the
standardmaterial.linearrgba
branch
3 times, most recently
from
8074e2e
to
fc21890
Compare
|
I think your comments have been addressed, please re-review when you have time @alice-i-cecile |
alice-i-cecile
requested changes
May 24, 2024
andristarr
force-pushed
the
standardmaterial.linearrgba
branch
from
fc21890
to
414833f
Compare
tychedelia
approved these changes
May 24, 2024
alice-i-cecile
approved these changes
May 24, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
|
This PR broke bloom, as you can see if you run example |
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 25, 2024
) # Objective - #13352 broke bloom in 3d ## Solution - Use the correct value for `emissive` in `StandardMaterial`. It's computed just above but unused https://github.com/bevyengine/bevy/blob/d87505899fc6adcb1a26550e921b0f5b0c351c57/crates/bevy_pbr/src/pbr_material.rs#L975-L976 ## Testing - Run example `bloom_3d`
|
Why did this PR change a bunch of examples to not use the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StandardMaterial stores a LinearRgba instead of a Color for emissive
Fixes #13212