Add reflect impls for bevy_math curve structs #13348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrGVSV
added
C-Usability
MrGVSV
reviewed
May 13, 2024
| @@ -42,7 +42,8 @@ use thiserror::Error; | |||
| /// ``` | |||
| #[derive(Clone, Debug)] | |||
| pub struct CubicBezier<P: VectorSpace> { | |||
| control_points: Vec<[P; 4]>, | |||
| /// The control points of the Bezier curve | |||
| pub control_points: Vec<[P; 4]>, | |||
There was a problem hiding this comment.
I can't speak for bevy_math folks, so I'll just ask: is there any reason we would want these to stay private?
There was a problem hiding this comment.
I can't see one. There's no invariants to uphold, and these math types don't have much room for implementation details to change. But happy to hear other thoughts.
There was a problem hiding this comment.
These are fine to be pub.
alice-i-cecile
approved these changes
May 16, 2024
MrGVSV
approved these changes
May 16, 2024
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #13189
Solution
To add the reflect impls I needed to make all the struct fields pub. I don't think there's any harm for these types, but just a note for review.