Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extrusion bounded #13346

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Extrusion bounded #13346

wants to merge 10 commits into from
+455 −0

Conversation

solis-lumine-vorago
Copy link
Contributor

@solis-lumine-vorago solis-lumine-vorago commented May 13, 2024 •
edited

Objective

  • Implement Bounded3d for some Extrusion<T>

Solution

  • Implemented Bounded3d for all 2D bevy_math primitives with the exception of Plane2d. As far as I can see, Plane2d is pretty much a line? and I think it is very unintuitive to extrude a plane and get a plane as a result.

Testing

  • Bounds for extrusions are tested within the same module. All unique implementations are tested.

@NthTensor NthTensor added C-Enhancement A new feature A-Math Fundamental domain-agnostic mathematical operations labels May 13, 2024
IQuick143
IQuick143 reviewed May 28, 2024
View reviewed changes
Copy link
Contributor

@IQuick143 IQuick143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the code is good, although I haven't looked through the ellipse code and the tests yet.

crates/bevy_math/src/bounding/bounded3d/extrusion.rs Outdated Show resolved Hide resolved
@solis-lumine-vorago @IQuick143
Simplify Extrusion<Circle>
6f22ad7 
Co-Authored-By: IQuick 143 <IQuick143cz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IQuick143 IQuick143 IQuick143 left review comments

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Enhancement A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@solis-lumine-vorago @IQuick143 @NthTensor