Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added explicit roofs to hub version 2 #73784

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

PatrikLundell
Copy link
Contributor

@PatrikLundell PatrikLundell commented May 14, 2024

Summary

None

Purpose of change

Add explicit roofs to field basecamp version 2, plus vent pipe/chimney on top of stove/fireplace.

Describe the solution

Make use of the 3D specification functionality.

Describe alternatives you've considered

Not cutting a hole in the tent for stove/fireplace.

Testing

  • Constructed one each of fireplace/stove with tent.
  • Constructed all tents plus center in 4 materials with stove and fireplace.
  • Constructed one each of foreplace/stove with shack.
  • Constructed the whole base out of remaining materials plus mi-go resin for the remainder (easiest to spawn).

Note that the common, unchanged, constructions weren't tested (apart from a well, as I needed the water for construction).

Screenshot (352)
Screenshot (351)
Screenshot (350)
Screenshot (349)
Screenshot (348)
Screenshot (347)

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 14, 2024
@dseguin dseguin merged commit 24f989c into CleverRaven:master May 14, 2024
24 of 29 checks passed
@PatrikLundell PatrikLundell deleted the base_2 branch May 15, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants