Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #70589 and #70770 #73773

Merged
merged 2 commits into from
May 15, 2024
Merged

Backport #70589 and #70770 #73773

merged 2 commits into from
May 15, 2024

Conversation

Procyonae
Copy link
Contributor

Summary

Bugfixes "Check validity of Win32 file names"

Purpose of change

#70589 solves a release blocker and #70770 is labelled for backport and fixes a gamebreaking bug introduced by #70589

Describe the solution

Backport #70589 and #70770

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) <Enhancement / Feature> New features, or enhancements on existing Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels May 14, 2024
@Procyonae Procyonae marked this pull request as draft May 14, 2024 15:03
@Procyonae

This comment was marked as outdated.

Sign in to view
Procyonae and others added 2 commits May 14, 2024 16:55
@Procyonae @alef
Check validity of Win32 file names
79aae0b 
Co-Authored-By: alef <3899581+alef@users.noreply.github.com>
@Qrox @Procyonae
. and .. are valid paths (CleverRaven#70770)
0be5a03
@Procyonae Procyonae marked this pull request as ready for review May 14, 2024 15:57
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 14, 2024
@Maleclypse Maleclypse merged commit 27059e7 into CleverRaven:0.H-branch May 15, 2024
22 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Character / World Generation Issues and enhancements concerning stages of creating a character or a world Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Procyonae @Maleclypse @Qrox