Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Update Dark Sight to scale with spell level #73769

Merged
merged 4 commits into from
May 17, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented May 14, 2024

Summary

Mods "[Magiclysm] Update Dark Sight to scale with spell level"

Purpose of change

Dark Sight gives you full night vision, which was the only possibility when it was written, but now we have better tools.

Describe the solution

Change the night vision granted from "Like night vision googles" to "3 squares plus 1 per level."

Since the spell is now less powerful, change the Difficulty to 2 (from 6) and mana cost to 175 (from 500). Also remove the range--since it's self-only anyway, this saves an extra click.

Describe alternatives you've considered

Testing

Tested and it works properly

Additional context

Found more spells that I can add scaling to now that there are better enchants out there. More PRs coming probably.

@Standing-Storm Standing-Storm marked this pull request as draft May 14, 2024 14:08
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells labels May 14, 2024
@github-actions github-actions bot requested a review from KorGgenT May 14, 2024 14:08
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label May 14, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 14, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review May 16, 2024 04:36
@Maleclypse Maleclypse merged commit a3c6367 into CleverRaven:master May 17, 2024
20 of 24 checks passed
@Standing-Storm Standing-Storm deleted the dark-sight-enchant branch May 19, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants