Craftable chest freezer #73762
Craftable chest freezer #73762
Conversation
Confirmed recipe is working, increased the crafting requirements. Chest freezer has a surface area roughly 50% greater than the household freezer, so I increased the requirements by about 50% for structural materials.
github-actions
bot
added
[JSON]
| { "id": "WRENCH", "level": 1 } | ||
| ], | ||
| "components": [ | ||
| [ [ "sheet_metal", 30 ] ], |
There was a problem hiding this comment.
Something went horrendously wrong here. This is 180kg alone, a chest freezer is 50kg. It's also almost 15 m2, so are you sure the surface area here is right?
There was a problem hiding this comment.
As mentioned under additional context I think all refrigeration needs a wider audit as I don't think any of them are currently correct.
I based surface area off of the relative increase between the household freezer and the chest freezer, rather than the surface area of the sheet metal.
I could amend this recipe to be 10 sheet metal, which would be roughly accurate to the ~4.571m^2 surface area of the chest freezer, but then it would use the same amount of sheet metal as a minifreezer and half that of a household freezer.
Given that I wasn't really sure what I was doing with this pull request (I've never submitted a pull request on github before) I wanted to Keep It Simple Stupid for myself, to make sure I knew how to make a submission before going back in later and fixing all the recipes and adding in the rest of the missing recipes, which seemed like the best option for me as a first-time contributor.
You're absolutely correct though, the recipes are pretty wrong right now, but the issue came before my PR.
There was a problem hiding this comment.
As mentioned under additional context I think all refrigeration needs a wider audit as I don't think any of them are currently correct.
They were just added, and Guardian cited their sources in JSON comments. I don't think they're blatantly incorrect, because I know Guardian spent weeks hunting the numbers down. The weight does seem suspiciously low, but they're definitely not all incorrect.
You're absolutely correct though, the recipes are pretty wrong right now, but the issue came before my PR.
Yeah, but you shouldn't make the issue worse by adding more to it. I don't expect you to audit all fridge recipes, but don't copy over their mistakes. Please make sure the weight at least adds up. We really desperately need to stop normalizing the violation of laws of physics in recipes...
There was a problem hiding this comment.
They were just added, and Guardian cited their sources in JSON comments. I don't think they're blatantly incorrect, because I know Guardian spent weeks hunting the numbers down. The weight does seem suspiciously low, but they're definitely not all incorrect.
I should clarify I meant that the recipes were incorrect not the specs on the fridges and freezers.
If they're going to be craftable there is an argument for adjusting the weight of some of these, as I imagine they're probably not using the same sheet metal we are to achieve some of these weights, but that's a compromise on reality that I'm not sure can easily be squared away unless we add in a "makeshift freezer" variant on all freezers.
Yeah, but you shouldn't make the issue worse by adding more to it. I don't expect you to audit all fridge recipes, but don't copy over their mistakes. Please make sure the weight at least adds up. We really desperately need to stop normalizing the violation of laws of physics in recipes...
Fair point. as I said, I was trying to opt for consistency, before going in and fixing all the recipes with a second PR once I was more confident, but I could quickly fix this one instead, though it will end up being wildly unbalanced in the short term.
There was a problem hiding this comment.
Reverted to draft while I resolve the recipe
github-actions
bot
added
json-styled
Summary
Balance "Adds a crafting recipe for chest freezers"
Purpose of change
Adds a crafting recipe for chest freezers. Chest freezers were replaced by the current household freezers, and are in the most reductive terms just a household freezer turned onto its side, so it makes sense to be able to craft these, given all components are readily accessible.
Describe the solution
Added in the recipe. Requirements are based upon the relative surface area between the chest freezer and the household freezer. Chest freezer has a surface area of roughly +50% so several components have had their requirements increased by 50% for this recipe.
Describe alternatives you've considered
Leaving the recipe out entirely.
Amending the crafting recipe to use welding proficiency. I still think this might be useful, but as this is my first contribution I wanted to keep it simple stuip
Testing
Confirmed that the recipe was accessible in game using debug to give myself the required skills, books and components.
Additional context
It may be useful to recipe audit refrigeration appliances at some point, as the recipes seem to be a little odd compared to the results. This seemed like too large of a scope for me right now, but many refrigeration appliances have been changed by #73048 and the recipes might need to be reworked as a result.