fix assert in diary info panel clamp #73758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Info / User Interface
with -D_GLIBCXX_ASSERTIONS=1, libstdc++ will assert when `lo > hi` in std::clamp, and it is described as undefined behavior in https://en.cppreference.com/w/cpp/algorithm/clamp. fix the arguments to avoid it.
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "fix assert in diary info panel clamp"
Purpose of change
with -D_GLIBCXX_ASSERTIONS=1, libstdc++ will assert when
lo > hiin std::clamp, and it is described as undefined behavior in https://en.cppreference.com/w/cpp/algorithm/clamp. fix the arguments to avoid it.Describe the solution
Describe alternatives you've considered
Testing
Additional context