fix draw_critter_above bounds check #73756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "fix draw_critter_above bounds check"
Purpose of change
when walking up the z levels, make sure we don't go out of bounds in the caches.
PR #73653 tried to fix this, but the check needs to happen before we index the cache array by z-level, not after.
fixes #73754.
Describe the solution
Describe alternatives you've considered
Testing
#73754 (comment) no longer crashes.
Additional context