Add tarot cards and Ouija board #73752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tarot cards as a variant of playing cards. Adds Ouija board to list of board games.
Adds tarot cards as a variant of the deck of cards. Adds Ouija board to pool of board games.
Fix hard crash
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Qrox
reviewed
May 14, 2024
Co-authored-by: Jianxiang Wang (王健翔) <qrox@sina.com>
Co-authored-by: Jianxiang Wang (王健翔) <qrox@sina.com>
Co-authored-by: Jianxiang Wang (王健翔) <qrox@sina.com>
github-actions
bot
added
json-styled
|
Maybe we could add something in w/ portal storms? |
|
Am I missing anything that would allow merging? I just want to make sure, I'm new at doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Content "Added tarot cards as a variant of playing cards and added Ouija board as a playable board game."
Purpose of change
I noticed a lack of mystically inclined games and decided to add them.
Describe the solution
Added these games into Cataclysm.
Describe alternatives you've considered
Not having these games. Nothing horrible would happen but it would be an opportunity not taken.
Testing
Used the debug menu to spawn in both the tarot cards and Ouija board. Successfully played them like any other game.
Additional context
First time contributing anything. We'll see how it goes.