Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Up Travel Toilets #73734

Merged
merged 4 commits into from
May 16, 2024
Merged

Conversation

TheMurderUnicorn
Copy link
Contributor

@TheMurderUnicorn TheMurderUnicorn commented May 13, 2024

Summary

Balance "Fix Up Travel Toilets"

Purpose of change

Well it started by noticing that travel toilets (portable plastic toilets) smashed for various metal pieces. And that didn't make sense. Unfortunately, I ended up going down the rabbit hole and changing a lot more.

Describe the solution

  • Edit travel toilet furniture in general to fix all the copy-from toilet stuff that doesn’t make sense
    • add drag-ability
    • remove flag for spawning with toilet water
    • Allow for simple deconstruction
    • change bash str/sound/materials/etc – It’s 3.5 lb there’s about 28-ish plastic chunks there, figure 15-30% for bash results. IE: 4-8 plastic chunks
  • Create travel toilet as an item
    Item was based on: https://www.amazon.com/PAHTTO-Portable-Retractable-Waterproof-Carrying/dp/B0B6YXPP4J
    • Volume = 13”x 11”x 11.8” + an online calculator = 27.651 liters.
    • Weight listed 3.5 lb (1587 grams).
    • Originally planned to let it hold water, but this one appears foldable/collapsible. They’re all meant to use bags but some are watertight, this one does not appear to be. So, no pocket for liquids. Pocket for non liquids, based on the 6-8 gallon bags used, I’ll call it 6 gallons, as this puts it slightly below the overall items volume.
    • Pocket max-weight, well, it’s not designed for containing heavy objects, its rated for 400 lb on top but that's not the same as containing? and it’s collapsible, so let’s say… 6 kg? This might be super wrong.
  • Add folded travel toilet as an item.
    • No idea what to make the volume honestly, figured it’s about the same ‘height’ (let’s pretend the lid doesn’t come off), the pictures don’t show this version as fully collapsed, only partly folded. I have no idea how to math this so I’ll pick an arbitrary thickness and say each panel is foldable into one stack, let’s call it two liters.
  • Allow folded and unfolded toilets to be constructed into the furniture version through construction menu.
  • Put them in the same group so it's not more clutter than necessary.

Describe alternatives you've considered

Just changing the metal drops from bashing as initially intended. I don't know the rules about cosmetic only furniture, but it already existed so why not let us take it down and place it ourselves?

Testing

This actually took me forever because I didn't really know what I was doing, so I tested to make sure everything works, transforms correctly, is constructable/deconstructable using simple deconstruct, etc. I saw no issues.

Additional context

idk man I didn't even want to do this. I just wanted to use the portable toilet in a mapgen location and noticed the materials were messed up and it snowballed into this. But as I've been playing House Flipper, I like the idea of being able to carry and construct this furniture for my base, even if it doesn't have actual functionality, especially since this furniture already existed. Might as well be able to construct it.

Pictures:
image
image

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 13, 2024
@github-actions github-actions bot added the Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. label May 15, 2024
@dseguin dseguin merged commit 2a9a5a5 into CleverRaven:master May 16, 2024
20 of 24 checks passed
@TheMurderUnicorn TheMurderUnicorn deleted the TravelToiletStuff branch May 16, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants