Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Aftershock ] Adjust some trait names and descriptions to Aftershock lore #73651

Merged
merged 4 commits into from
May 19, 2024

Conversation

Maleclypse
Copy link
Member

Summary

None

Purpose of change

Adjust traits to Aftershock Lore

Describe the solution

Adds new names and descriptions.

Describe alternatives you've considered

Blacklisting these traits

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Mods: Aftershock Anything to do with the Aftershock mod labels May 11, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label May 11, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 11, 2024
@John-Candlebury
Copy link
Member

I kinda feel like we might not need to actually overwrite these traits over just making new ones.

Most of their hardcoded effects are partially obsolete now.

@Maleclypse
Copy link
Member Author

I kinda feel like we might not need to actually overwrite these traits over just making new ones.

Most of their hardcoded effects are partially obsolete now.

So just create new id's for all of them and we can utilize them in EOCs and dialogue as we decide to?

@John-Candlebury
Copy link
Member

Yeah I think it might make maintenance easier in the long run.

data/mods/Aftershock/mutations/mutations.json Outdated Show resolved Hide resolved
data/mods/Aftershock/mutations/mutations.json Outdated Show resolved Hide resolved
data/mods/Aftershock/mutations/mutations.json Outdated Show resolved Hide resolved
data/mods/Aftershock/mutations/mutations.json Outdated Show resolved Hide resolved
data/mods/Aftershock/mutations/mutations.json Outdated Show resolved Hide resolved
data/mods/Aftershock/mutations/mutations.json Outdated Show resolved Hide resolved
Co-authored-by: John Candlebury <johncandlebury@gmail.com>
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • As a member of the Astrographic and Gatepoint Division you are responsible for spreading the boundaries of the Frontiers and protecting interstellar travel. This gives you wide ranging latitude when it comes to addressing threats to interstellar travel. Does this technically make you a member of UICA's very own secret police? Yes, yes it does.
  • Pinkerton
  • UICA Astrographic and Gatepoint Agent

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@dseguin dseguin merged commit 64c1fed into CleverRaven:master May 19, 2024
19 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants