Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Craft, Uncraft, Furniture version, and Construction to Fancy Tables #73642

Merged
merged 5 commits into from
May 16, 2024

Conversation

TheMurderUnicorn
Copy link
Contributor

@TheMurderUnicorn TheMurderUnicorn commented May 11, 2024

Summary

Balance "Add Craft, Uncraft, Furniture version, and Construction to Fancy Tables"

Purpose of change

While auditing the breaks_into for various vehicle parts, I discovered the ‘fancy table’. Installed in a vehicle this is just a table, but when removed gives a fancy table. Fancy table did not have a disassembly or crafting recipe, and could not be placed or crafted in the construction menu. There’s no reason I found that its not disassemblyablebl, and it not being place-able also makes no sense. It's worth noting that the wooden table also becomes a 'table' in a vehicle, but can be placed/used as a proper table through construction, so I sought to make something similar.

Describe the solution

Steps I took/Notes:

  • Remove ‘from a very fancy RV’ from the item description – it’s currently found in limos, tour buses, and the luxury RV, so the description is already inaccurate. My changes will make it even less accurate, so I’ll change this. Also add looks_like w_table just so it has something to point at if either would ever get a sprite. EDIT: Chose not to add looks_like because it looks like some things copy-from this and it might cause issues?
  • Add Recipe – line 615 ish recipes/recipe_others.json
  • Add Disassembly Recipe – Slightly different return since some wood is lost from carving/shaping and put it wherever in recipes/recipes_deconstruction.json no other tables listed
  • Add Furniture version of fancy table – after f_table around 295 in furniture_and_terrain/furniture-surfaces.json
  • Add Construction for placing fancy table around 2258 under place_table in construction.json

Change the ID? It’s tagged as v_table, which makes it seem vehicle only… idk I’m so lazy… I didn’t do it x_x

I have added a crafting and disassembly recipe, for those that want to make a fancier version of a table or use it in their vehicle for whatever reason. I’ve added a place construction to set down an existing fancy table. Although this is basically the same functionality as any other table, since the item already exists we might as well make it use-able in all those circumstances, so I did. Slightly higher skills/prof required due to it being ‘fancy’, I’ve tweaked the description to make it sound fancier and justify the proficiencies. I chose not to add a construction recipe for making it from scratch, as you can just make it using the recipe (which requires proficiencies and etc. that cannot be attached to constructions (that I saw?)), this prevented it from having two entries in construction, the only one I added was to place the existing item, turning it into the furniture version, which can then be taken down using simple deconstruct to return it to item form. I placed the 'place' construction in the same group as a standard table to avoid clutter.

Describe alternatives you've considered

None, this is a masterful solution of which we can all be proud.

Testing

I tested each aspect of this as I went along, made sure no typos/syntax issues, didn't accidentally overspawn materials, etc, made sure it still made sense/was reasonable with proficiencies, etc. etc.

Additional context

So fancy your eyes will bleed

@github-actions github-actions bot added Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels May 11, 2024
@Maleclypse
Copy link
Member

Conflict resolution required

@dseguin dseguin merged commit d435fb1 into CleverRaven:master May 16, 2024
18 of 24 checks passed
@TheMurderUnicorn TheMurderUnicorn deleted the MostFanciestTable branch May 16, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants