Use six instead of scipy._lib.six #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of scipy do not have scipy._lib.six module (probably because they don't support python 2 anymore). So importing skgof throws ModuleNotFoundError. This commit adds an explicit dependency on six and uses that directly instead of using the scipy._lib.six module. Another easy way to fix it that does not need extra dependency would be to drop support for python 2 and just use str instead of six.string_types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
Newer versions of scipy do not have scipy._lib.six module (probably
because they don't support python 2 anymore). So importing skgof
throws ModuleNotFoundError.
This commit adds an explicit dependency on six and uses that directly
instead of using the scipy._lib.six module.
Another easy way to fix it that does not need extra dependency
would be to drop support for python 2 and just use str instead of
six.string_types.