perf(wpf): Replace Reflection with PInovke win32 in WpfKeyboardInputSource #16670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/skia ✏️
Youssef1313
reviewed
May 10, 2024
Youssef1313
approved these changes
May 10, 2024
lindexi
added a commit
to lindexi/uno
that referenced
this pull request
May 10, 2024
6 tasks
lindexi
added a commit
to lindexi/uno
that referenced
this pull request
May 10, 2024
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16670/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16670/index.html |
|
@lindexi Thank you for the contribution! |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We have to do Reflection on every keyboard event in wpf.
What is the new behavior?
We will call the win32 method the get the scan code.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Reference #14371 (comment) and dotnet/wpf#8473 (comment)
Internal Issue (If applicable):