fix(gtk): Fix get scan code in GtkKeyboardInputSource #16671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/skia ✏️
lindexi
force-pushed
the
t/lindexi/GtkKeyboardInputSource
branch
from
bd29ba1
to
8ad0fbd
Compare
Youssef1313
reviewed
May 10, 2024
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16671/index.html |
1 similar comment
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16671/index.html |
ramezgerges
approved these changes
May 10, 2024
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16671/index.html |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jeromelaban
approved these changes
May 10, 2024
|
Thanks for your contribution! |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16671/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16671/index.html |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Now the GtkKeyboardInputSource will use the InputHelper.TryConvertKeyCodeToScanCode to convert the key code to scan code which will always return false. It means the scan code same as the key code.
What is the new behavior?
The GtkKeyboardInputSource will use the gtk to get the scan code
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
See https://docs.gtk.org/gdk3/method.Event.get_scancode.html
Reference #16670
Origin commit : 98c965a
Cc @ramezgerges
Internal Issue (If applicable):