Fix bug when converting results from the HEKClient #7627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #5006 (comment) |
nabobalis
added
Minor Change
|
Thanks for the PR @bmampaey, can you add a changelog entry marking this as a bugfix? We have some details on the readme here: https://github.com/sunpy/sunpy/blob/main/changelog/README.rst |
|
Thanks for the changelog, can you tell me what query failed for you? |
|
I specified it in the issue #5006 (comment) It was from sunpy.net.hek import HEKClient
from sunpy.net import attrs as a
results = HEKClient().search(a.Time('2024-05-10', '2024-05-12'), a.hek.AR.NOAANum == 13664) |
…ime failed when some values where empty or missing
nabobalis
force-pushed
the
null-hek-time-values
branch
from
d74edc0
to
3d19583
Compare
nabobalis
approved these changes
May 15, 2024
nabobalis
added
the
Merge When CI Passes
|
Thanks for the PR @bmampaey |
meeseeksmachine
pushed a commit
to meeseeksmachine/sunpy
that referenced
this pull request
May 15, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/sunpy
that referenced
this pull request
May 15, 2024
nabobalis
added a commit
that referenced
this pull request
May 15, 2024
…7-on-5.0 Backport PR #7627 on branch 5.0 (Fix bug when converting results from the HEKClient )
nabobalis
added a commit
that referenced
this pull request
May 15, 2024
…7-on-5.1 Backport PR #7627 on branch 5.1 (Fix bug when converting results from the HEKClient )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fixes bug where convertion of results from the HEKClient to Astropy Time failed when some values where empty or missing