Merge pull request #7630 from meeseeksmachine/auto-backport-of-pr-762…

…7-on-5.1

Backport PR #7627 on branch 5.1 (Fix bug when converting results from the HEKClient )

changelog/7627.bugfix.rst

@@ -0,0 +1 @@
+Fixed bug where conversion of results from the HEKClient to Astropy Time failed when some values where empty or missing for the values of event_strattime, event_endtime or event_peaktime

sunpy/net/hek/hek.py

@@ -7,6 +7,8 @@
 import inspect
 from itertools import chain
 
+import numpy.ma
+
 import astropy.table
 from astropy.table import Row
 
@@ -91,9 +93,10 @@ def _parse_times(table):
         # All time columns from https://www.lmsal.com/hek/VOEvent_Spec.html
         time_keys = ['event_endtime', 'event_starttime', 'event_peaktime']
         for tkey in time_keys:
-            if tkey in table.colnames and not any(time == "" for time in table[tkey]):
-                table[tkey] = parse_time(table[tkey])
-                table[tkey].format = 'iso'
+            if tkey in table.colnames:
+                table[tkey] = [
+                    (parse_time(time, format='iso') if time else numpy.ma.masked) for time in table[tkey]
+                ]
         return table
 
     def search(self, *args, **kwargs):

sunpy/net/hek/tests/test_hek.py

@@ -1,5 +1,6 @@
 import copy
 
+import numpy as np
 import pytest
 
 from astropy.time import Time
@@ -218,3 +219,12 @@ def test_query_multiple_operators():
                             attrs.hek.FL.GOESCls > "M1.0",
                             attrs.hek.OBS.Observatory == "GOES")
     assert len(results) == 7
+
+
+@pytest.mark.remote_data
+def test_missing_times():
+    # Check for https://github.com/sunpy/sunpy/pull/7627#issuecomment-2113451964
+    client = hek.HEKClient()
+    results = client.search(attrs.Time('2024-05-10', '2024-05-12'), attrs.hek.AR.NOAANum == 13664)
+    assert isinstance(results["event_peaktime"][0], np.ma.core.MaskedConstant)
+    assert results["event_peaktime"][1].isot == '2024-05-10T16:08:00.000'