Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge baseurl and pattern for scraper clients (#7077) #7227

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    ea6a405 View commit details
    Browse the repository at this point in the history
  2. precommit fixes

    nabobalis committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    b393491 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2024

  1. [scraper branch] added some bit of error handling in the scraper (#7541)

    * merge baseurl and pattern for scraper clients (#7077)
    
    * precommit fixes
    
    * added some bit of error handling in the scraper
    
    * Update sunpy/net/dataretriever/client.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * made some minor changes
    
    * Update sunpy/net/scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * added some changes to the scraper and also added the tentative tests
    
    * modified tests
    
    * added some bit of error handling in the scraper
    
    * made some minor changes
    
    * Update sunpy/net/dataretriever/client.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * added some changes to the scraper and also added the tentative tests
    
    * Update sunpy/net/scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * modified tests
    
    * refactored the tests to scraper test files and restored the scraper code
    
    * Update sunpy/net/scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * clean ups
    
    * Update sunpy/net/scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * made tests offline
    
    * Update sunpy/net/scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/tests/test_scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/tests/test_scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/tests/test_scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * added urlerror test
    
    * Update sunpy/net/tests/test_scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * resolved conflicts
    
    * clean ups
    
    * parametrized
    
    * clean ups
    
    * Update sunpy/net/tests/test_scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * clean ups
    
    * added explanation
    
    * Update sunpy/net/tests/test_scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/tests/test_scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * added 404 test
    
    * parametrized the tests
    
    * Update sunpy/net/tests/test_scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/tests/test_scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/tests/test_scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * log level set
    
    * Update sunpy/net/scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/tests/test_scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/tests/test_scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * log level using caplog
    
    * log level using caplog
    
    * Update sunpy/net/tests/test_scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/tests/test_scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/tests/test_scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/tests/test_scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    * Update sunpy/net/tests/test_scraper.py
    
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    
    ---------
    
    Co-authored-by: Akshit Tyagi <37214399+exitflynn@users.noreply.github.com>
    Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
    3 people committed Apr 7, 2024
    Configuration menu
    Copy the full SHA
    fb8a1d5 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. fix failing windows tests

    exitflynn committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    9900ab9 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #7601 from exitflynn/scraper_rewrite

    fix failing windows tests
    nabobalis committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    c46ab8d View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Configuration menu
    Copy the full SHA
    7c7f600 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. fix the docs-build CI test

    exitflynn committed May 18, 2024
    Configuration menu
    Copy the full SHA
    1376939 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #7632 from exitflynn/scraper_rewrite

    fix the failing build-docs test
    nabobalis committed May 18, 2024
    Configuration menu
    Copy the full SHA
    3298b98 View commit details
    Browse the repository at this point in the history