-
-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge baseurl and pattern for scraper clients (#7077) #7227
Draft
nabobalis
wants to merge
8
commits into
main
Choose a base branch
from
scraper_rewrite
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Apr 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ea6a405 - Browse repository at this point
Copy the full SHA ea6a405View commit details -
Configuration menu - View commit details
-
Copy full SHA for b393491 - Browse repository at this point
Copy the full SHA b393491View commit details
Commits on Apr 7, 2024
-
[scraper branch] added some bit of error handling in the scraper (#7541)
* merge baseurl and pattern for scraper clients (#7077) * precommit fixes * added some bit of error handling in the scraper * Update sunpy/net/dataretriever/client.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * made some minor changes * Update sunpy/net/scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * added some changes to the scraper and also added the tentative tests * modified tests * added some bit of error handling in the scraper * made some minor changes * Update sunpy/net/dataretriever/client.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * added some changes to the scraper and also added the tentative tests * Update sunpy/net/scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * modified tests * refactored the tests to scraper test files and restored the scraper code * Update sunpy/net/scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * clean ups * Update sunpy/net/scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * made tests offline * Update sunpy/net/scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/tests/test_scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/tests/test_scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/tests/test_scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * added urlerror test * Update sunpy/net/tests/test_scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * resolved conflicts * clean ups * parametrized * clean ups * Update sunpy/net/tests/test_scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * clean ups * added explanation * Update sunpy/net/tests/test_scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/tests/test_scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * added 404 test * parametrized the tests * Update sunpy/net/tests/test_scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/tests/test_scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/tests/test_scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * log level set * Update sunpy/net/scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/tests/test_scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/tests/test_scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * log level using caplog * log level using caplog * Update sunpy/net/tests/test_scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/tests/test_scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/tests/test_scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/tests/test_scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Update sunpy/net/tests/test_scraper.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> --------- Co-authored-by: Akshit Tyagi <37214399+exitflynn@users.noreply.github.com> Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fb8a1d5 - Browse repository at this point
Copy the full SHA fb8a1d5View commit details
Commits on Apr 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9900ab9 - Browse repository at this point
Copy the full SHA 9900ab9View commit details -
Merge pull request #7601 from exitflynn/scraper_rewrite
fix failing windows tests
Configuration menu - View commit details
-
Copy full SHA for c46ab8d - Browse repository at this point
Copy the full SHA c46ab8dView commit details
Commits on Apr 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7c7f600 - Browse repository at this point
Copy the full SHA 7c7f600View commit details
Commits on May 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1376939 - Browse repository at this point
Copy the full SHA 1376939View commit details -
Merge pull request #7632 from exitflynn/scraper_rewrite
fix the failing build-docs test
Configuration menu - View commit details
-
Copy full SHA for 3298b98 - Browse repository at this point
Copy the full SHA 3298b98View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.