Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge baseurl and pattern for scraper clients (#7077) #7227

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Merge pull request #7632 from exitflynn/scraper_rewrite

3298b98
Select commit
Failed to load commit list.
Draft

merge baseurl and pattern for scraper clients (#7077) #7227

Merge pull request #7632 from exitflynn/scraper_rewrite
3298b98
Select commit
Failed to load commit list.
Codecov / codecov/patch failed May 18, 2024 in 1s

79.93% of diff hit (target 95.73%)

View this Pull Request on Codecov

79.93% of diff hit (target 95.73%)

Annotations

Check warning on line 236 in sunpy/net/dataretriever/client.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/dataretriever/client.py#L235-L236 

Added lines #L235 - L236 were not covered by tests

Check warning on line 238 in sunpy/net/dataretriever/client.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/dataretriever/client.py#L238 

Added line #L238 was not covered by tests

Check warning on line 131 in sunpy/net/dataretriever/sources/goes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/dataretriever/sources/goes.py#L131 

Added line #L131 was not covered by tests

Check warning on line 133 in sunpy/net/dataretriever/sources/goes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/dataretriever/sources/goes.py#L133 

Added line #L133 was not covered by tests

Check warning on line 136 in sunpy/net/dataretriever/sources/goes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/dataretriever/sources/goes.py#L136 

Added line #L136 was not covered by tests

Check warning on line 148 in sunpy/net/dataretriever/sources/goes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/dataretriever/sources/goes.py#L148 

Added line #L148 was not covered by tests

Check warning on line 155 in sunpy/net/dataretriever/sources/goes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/dataretriever/sources/goes.py#L155 

Added line #L155 was not covered by tests

Check warning on line 165 in sunpy/net/dataretriever/sources/goes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/dataretriever/sources/goes.py#L165 

Added line #L165 was not covered by tests

Check warning on line 170 in sunpy/net/dataretriever/sources/goes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/dataretriever/sources/goes.py#L170 

Added line #L170 was not covered by tests

Check warning on line 300 in sunpy/net/dataretriever/sources/goes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/dataretriever/sources/goes.py#L299-L300 

Added lines #L299 - L300 were not covered by tests

Check warning on line 303 in sunpy/net/dataretriever/sources/goes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/dataretriever/sources/goes.py#L303 

Added line #L303 was not covered by tests

Check warning on line 308 in sunpy/net/dataretriever/sources/goes.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/dataretriever/sources/goes.py#L306-L308 

Added lines #L306 - L308 were not covered by tests

Check warning on line 68 in sunpy/net/dataretriever/sources/norh.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/dataretriever/sources/norh.py#L68 

Added line #L68 was not covered by tests

Check warning on line 192 in sunpy/net/scraper.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/scraper.py#L192 

Added line #L192 was not covered by tests

Check warning on line 196 in sunpy/net/scraper.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/scraper.py#L195-L196 

Added lines #L195 - L196 were not covered by tests

Check warning on line 198 in sunpy/net/scraper.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/scraper.py#L198 

Added line #L198 was not covered by tests

Check warning on line 217 in sunpy/net/scraper.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/scraper.py#L216-L217 

Added lines #L216 - L217 were not covered by tests

Check warning on line 269 in sunpy/net/scraper.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/scraper.py#L263-L269 

Added lines #L263 - L269 were not covered by tests

Check warning on line 274 in sunpy/net/scraper.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/scraper.py#L271-L274 

Added lines #L271 - L274 were not covered by tests

Check warning on line 276 in sunpy/net/scraper.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/scraper.py#L276 

Added line #L276 was not covered by tests

Check warning on line 293 in sunpy/net/scraper.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/scraper.py#L291-L293 

Added lines #L291 - L293 were not covered by tests

Check warning on line 308 in sunpy/net/scraper.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/scraper.py#L307-L308 

Added lines #L307 - L308 were not covered by tests

Check warning on line 330 in sunpy/net/scraper.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/scraper.py#L330 

Added line #L330 was not covered by tests

Check warning on line 339 in sunpy/net/scraper.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/scraper.py#L335-L339 

Added lines #L335 - L339 were not covered by tests

Check warning on line 132 in sunpy/net/tests/test_scraper.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

sunpy/net/tests/test_scraper.py#L132 

Added line #L132 was not covered by tests
View more details on Codecov