Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check and ignoring nulls when using reflection. #1403

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check and ignoring nulls when using reflection. #1403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Spectre.Console/Widgets/Exceptions/ExceptionFormatter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,15 +303,16 @@ private static bool TryGetTupleName(ParameterInfo parameter, Type parameterType,
.FirstOrDefault(a =>
{
var attributeType = a.GetType();
return attributeType.Namespace == "System.Runtime.CompilerServices" &&
return attributeType != null &&
attributeType.Namespace == "System.Runtime.CompilerServices" &&
attributeType.Name == "TupleElementNamesAttribute";
});

if (tupleNameAttribute != null)
{
var propertyInfo = tupleNameAttribute.GetType()
.GetProperty("TransformNames", BindingFlags.Instance | BindingFlags.Public)!;
var tupleNames = propertyInfo.GetValue(tupleNameAttribute) as IList<string>;
.GetProperty("TransformNames", BindingFlags.Instance | BindingFlags.Public);
var tupleNames = propertyInfo?.GetValue(tupleNameAttribute) as IList<string>;
if (tupleNames?.Count > 0)
{
var args = parameterType.GetGenericArguments();
Expand Down