[BUG] fix ProximityForest
, tree, stump, and IndividualBOSS
returning y
of different type in predict
#6432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #6431.
Fixes
ProximityForest
, tree, stump, andIndividualBOSS
returningy
of different type inpredict
.The
IndividualBOSS
was coercing toobject
which was turned of.The proximity classifiers had
_predict
being copy-paste of the default_predict
which was fixed in #6430. The fix is deduplication, so the_predict
defaults to the fixed parent classes' predict.Tested via #6428