Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] fix classifiers erroneously failing on non-int typed y #6431

Closed
3 tasks done
fkiraly opened this issue May 16, 2024 · 0 comments · Fixed by #6432
Closed
3 tasks done

[BUG] fix classifiers erroneously failing on non-int typed y #6431

fkiraly opened this issue May 16, 2024 · 0 comments · Fixed by #6432
Labels
bug Something isn't working module:classification classification module: time series classification

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented May 16, 2024 •
edited

PR #6428 has flagged some additional classifiers returning int y or changing dtype on predict, or simply failing, besides those that rely on the default _predict.

These should be fixed:
@fkiraly fkiraly added bug Something isn't working module:classification classification module: time series classification labels May 16, 2024
@fkiraly fkiraly changed the title [BUG] fix classifiers erroneously returning int y or change dtype on predict [BUG] fix classifiers erroneously failing on non-int typed y May 16, 2024
@fkiraly fkiraly mentioned this issue May 16, 2024
Merged
@fkiraly fkiraly linked a pull request May 16, 2024 that will close this issue
[BUG] fix ProximityForest, tree, stump, and IndividualBOSS returning y of different type in predict #6432
Merged
fkiraly added a commit that referenced this issue May 22, 2024
@fkiraly
[BUG] fix ProximityForest, tree, stump, and IndividualBOSS return…
0af0772 
…ing `y` of different type in `predict` (#6432)

Towards #6431.

Fixes `ProximityForest`, tree, stump, and `IndividualBOSS` returning `y`
of different type in `predict`.

The `IndividualBOSS` was coercing to `object` which  was turned of.

The proximity classifiers had `_predict` being copy-paste of the default
`_predict` which was fixed in
#6430. The fix is deduplication, so
the `_predict` defaults to the fixed parent classes' predict.

Tested via #6428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working module:classification classification module: time series classification
Projects
None yet
Milestone
No milestone
1 participant
@fkiraly