-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize function signature of compare_images. #7322
Merged
Merged
Changes from 35 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
216a575
Remove obsolete instruction for documenting changes
mkcor 4f1e326
Merge branch 'main' of github.com:scikit-image/scikit-image
mkcor f5ba6ee
Deprecate parameter image2 and limit to two positional arguments
mkcor 44fdf66
Add test for replaced parameters
mkcor 32d09da
Use pytest
mkcor 96ea4d2
Cover all cases
mkcor 32eadf6
Remove unnecessary default value
mkcor 0e8bd61
Add directives for future release
mkcor 9784f80
Ensure valid existing code does not break
mkcor 535ed04
Handle deprecation in a custom way
mkcor 35c0db6
Capture all deprecation warnings
mkcor 3364ae1
Fix typo in test name
mkcor 234438a
Update instructions for future release
mkcor 7d5ae50
Merge branch 'main' of github.com:scikit-image/scikit-image
mkcor 2c51f12
Keep signature compatible with old API
mkcor 4fefbc5
Merge branch 'main' of github.com:scikit-image/scikit-image
mkcor 65177be
Update TODO
mkcor 3237cfc
Merge branch 'main' into image0-image1
mkcor 4b0c34b
Merge branch 'main' into image0-image1
mkcor e0d5929
Remove test for new API
mkcor d08d3b2
Remove warning test cases for new API
mkcor 878d15c
Write custom deprecation class
mkcor db1b774
Ensure images are 2D for method=checkerboard
mkcor c723c5d
Merge branch 'main' into image0-image1
mkcor 79acf77
Add edge case with positional args only
mkcor 9b9f757
Account for method-related warning
mkcor 1f93250
Refactor decorator
mkcor 7227424
Merge branch 'main' into image0-image1
mkcor 0756a56
Correct and test stacklevel of deprecation warnings
lagru 14e27e4
Update TODO.txt
mkcor 0f18d56
Apply suggestions from code review
mkcor 770499a
Fix typos
mkcor 17cfe64
Update deprecation messages to 0.24
lagru c44e916
Merge branch 'main' into pr/7322_image0-image1
lagru 9a10712
Use correct indent for versionchanged directive
lagru e406346
Merge branch 'main' into pr/7322_image0-image1
lagru File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkcor I corrected a minor indent issue in 9a10712. Also, I'm thinking about how we can reduce the visual noise these kind of directives create in our docs. E.g. this directive I'm commenting on doesn't seem all that useful. We should probably reserve using them for breaking changes when they are absolutely necessary to avoid user confusion. And do we plan on removing them ever? Curious what you think. :)
Let's merge once the CI is green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @lagru.
I guess it was useful back when the latest release was 0.16, 0.17, ... but it's losing this character of usefulness as time goes by, for sure.
I guess it's fair to be informative, even if the information isn't technically 'necessary.' When is it information, when does it become noise...? I can hear that we want to strike the right balance.
I thought that, since these directives existed, they were probably very useful somewhere somewhat... 🙄
I say we remove them in skimage2 😁