Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize function signature of compare_images. #7322

Merged
merged 36 commits into from
May 14, 2024
Merged

Standardize function signature of compare_images. #7322

merged 36 commits into from
May 14, 2024

Commits on Feb 16, 2024

  1. Remove obsolete instruction for documenting changes

    @mkcor
    mkcor committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    216a575 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:scikit-image/scikit-image

    @mkcor
    mkcor committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    4f1e326 View commit details
    Browse the repository at this point in the history

  3. Deprecate parameter image2 and limit to two positional arguments

    @mkcor
    mkcor committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    f5ba6ee View commit details
    Browse the repository at this point in the history

  4. Add test for replaced parameters

    @mkcor
    mkcor committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    44fdf66 View commit details
    Browse the repository at this point in the history

  5. Use pytest

    @mkcor
    mkcor committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    32d09da View commit details
    Browse the repository at this point in the history

  6. Cover all cases

    @mkcor
    mkcor committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    96ea4d2 View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary default value

    @mkcor
    mkcor committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    32eadf6 View commit details
    Browse the repository at this point in the history

  8. Add directives for future release

    @mkcor
    mkcor committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    0e8bd61 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Ensure valid existing code does not break

    @mkcor
    mkcor committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    9784f80 View commit details
    Browse the repository at this point in the history

  2. Handle deprecation in a custom way

    @mkcor
    mkcor committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    535ed04 View commit details
    Browse the repository at this point in the history

  3. Capture all deprecation warnings

    @mkcor
    mkcor committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    35c0db6 View commit details
    Browse the repository at this point in the history

  4. Fix typo in test name

    @mkcor
    mkcor committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    3364ae1 View commit details
    Browse the repository at this point in the history

  5. Update instructions for future release

    @mkcor
    mkcor committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    234438a View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Merge branch 'main' of github.com:scikit-image/scikit-image

    @mkcor
    mkcor committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7d5ae50 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Keep signature compatible with old API 

    Co-authored-by: Lars Grüter <lagru+github@mailbox.org>
    @mkcor @lagru
    mkcor and lagru committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    2c51f12 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:scikit-image/scikit-image

    @mkcor
    mkcor committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    4fefbc5 View commit details
    Browse the repository at this point in the history

  3. Update TODO

    @mkcor
    mkcor committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    65177be View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into image0-image1

    @mkcor
    mkcor committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    3237cfc View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Merge branch 'main' into image0-image1

    @mkcor
    mkcor committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    4b0c34b View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Remove test for new API

    @mkcor
    mkcor committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    e0d5929 View commit details
    Browse the repository at this point in the history

  2. Remove warning test cases for new API

    @mkcor
    mkcor committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    d08d3b2 View commit details
    Browse the repository at this point in the history

  3. Write custom deprecation class

    @mkcor
    mkcor committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    878d15c View commit details
    Browse the repository at this point in the history

  4. Ensure images are 2D for method=checkerboard

    @mkcor
    mkcor committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    db1b774 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into image0-image1

    @mkcor
    mkcor committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    c723c5d View commit details
    Browse the repository at this point in the history

  6. Add edge case with positional args only 

    Co-authored-by: Lars Grüter <lagru+github@mailbox.org>
    @mkcor @lagru
    mkcor and lagru committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    79acf77 View commit details
    Browse the repository at this point in the history

  7. Account for method-related warning

    @mkcor
    mkcor committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    9b9f757 View commit details
    Browse the repository at this point in the history

  8. Refactor decorator 

    Co-authored-by: Lars Grüter <lagru+github@mailbox.org>
    @mkcor @lagru
    mkcor and lagru committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    1f93250 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Merge branch 'main' into image0-image1

    @mkcor
    mkcor committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    7227424 View commit details
    Browse the repository at this point in the history

  2. Correct and test stacklevel of deprecation warnings 

    The previous default stacklevel wouldn't have shown a confusing origin
of the warning to users.
    @lagru
    lagru committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    0756a56 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Update TODO.txt 

    Co-authored-by: Lars Grüter <lagru+github@mailbox.org>
    @mkcor @lagru
    mkcor and lagru committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    14e27e4 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Lars Grüter <lagru+github@mailbox.org>
    @mkcor @lagru
    mkcor and lagru committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    0f18d56 View commit details
    Browse the repository at this point in the history

  3. Fix typos

    @mkcor
    mkcor committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    770499a View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Update deprecation messages to 0.24

    @lagru
    lagru committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    17cfe64 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into pr/7322_image0-image1

    @lagru
    lagru committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c44e916 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Use correct indent for versionchanged directive 

    and reduce visual noise. The first versionchanged already informs users
that image2 was deprecated.
    @lagru
    lagru committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    9a10712 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Merge branch 'main' into pr/7322_image0-image1

    @lagru
    lagru committed May 9, 2024
    Configuration menu
    Copy the full SHA
    e406346 View commit details
    Browse the repository at this point in the history