Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bin splitting to filters.rank.percentile_mean #7111

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Aug 28, 2023

  1. Add bin splitting to rank.percentile_mean

    The algorithm works by summing bins of a histogram of the surrounding
    neighborhood together while skipping bins outside the defined
    percentile. However, the previous implementation would only deal with
    complete bins leading to unexpected behavior when according to the
    given percentile, a part of a bin should factor into the mean. The
    new implementation fixes this problem, while increasing performance such
    that it is on par with rank.mean for most tested scenarios.
    lagru committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e5e62bb View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Ensure percentile interval is inclusive

    Previously, if a pixel was directly on the pixel border its value wasn't
    taken into account for the average. The new test, should ensure the
    behavior. Removing the extra `lower - 1` or `upper + 1` turns the test
    red.
    lagru committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    bad9976 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d5fc3aa View commit details
    Browse the repository at this point in the history