Add bin splitting to filters.rank.percentile_mean
#7111
Conversation
The algorithm works by summing bins of a histogram of the surrounding neighborhood together while skipping bins outside the defined percentile. However, the previous implementation would only deal with complete bins leading to unexpected behavior when according to the given percentile, a part of a bin should factor into the mean. The new implementation fixes this problem, while increasing performance such that it is on par with rank.mean for most tested scenarios.
Previously, if a pixel was directly on the pixel border its value wasn't taken into account for the average. The new test, should ensure the behavior. Removing the extra `lower - 1` or `upper + 1` turns the test red.
|
It's tricky to figure out the correct behavior for the edges of the inclusive percentile interval |
|
Hello scikit-image core devs! There hasn't been any activity on this PR for more than 180 days. I have marked it as "dormant" to make it easy to find. |
Description
Fixes #7096.
The algorithm works by summing bins of a histogram of the surrounding neighborhood together while skipping bins outside the defined percentile. However, the previous implementation would only deal with complete bins leading to unexpected behavior when according to the given percentile, a part of a bin should factor into the mean. The new implementation fixes this problem, while increasing performance such that it is on par with
rank.meanfor most tested scenarios.Checklist
./doc/examplesfor new featuresRelease note
Summarize the introduced changes in the code block below in one or a few sentences. The
summary will be included in the next release notes automatically: