Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework device matching | Store members in customData | Add AC Unit & Extended Fan #405

Merged
merged 16 commits into from
May 31, 2024

Conversation

michikrug
Copy link
Collaborator

@michikrug michikrug commented Oct 28, 2022

⚠️ Breaking Changes

  • As the group members are now stored in customData, existing (group) devices will only work after a new SYNC
  • The modes configuration for Thermostats has been renamed to thermostatModes - users will have to adjust their configuration
  • The speeds configuration for Fans has been renamed to fanSpeeds - users will have to adjust their configuration
  • As item types of group members will now be validated, you might see devices disappearing in Google Home if you used an unsupported item within a group device

⚙️ Changes

  • Item names for group members are stored in customData to save a query request to openHAB when executing commands (will supersede Rework device matching - Store members in customData #222)
    • For commands that need the current state the query request is still needed (thermostat commands or relative volume)
    • Also some other configuration options are stored in customData
    • Item types of group members will now be validated
    • There is no change on the user's side required but they will need to do a SYNC
  • Add a lot of new functionality to Fan devices (AirPurifier, Fan, Hood) (will supersede Add advanced Fan capabilities #221)
    • OnOff (separate power switch if used as a group)
    • FanSpeed (separate fan speed if used as a group)
    • Modes (yes, for the first time modes are available)
    • SensorState (for FilterLifeTime and PM2.5 - no clue how to query those)
  • Add AC Unit device (will supersede Adding AC_UNIT type #347 & Add ACUnit Device #358)
    • Basically just a combination of the extended Fan and the Thermostat with all control and config options of both

⁉️ Potential Issues

As customData is limited to 512 bytes it could be an issue to store very long item names e.g. for devices with a lot of members like thermostat (ref. developers.google.com/assistant/smarthome/reference/intent/sync)

@mbronk
Copy link

mbronk commented Jul 10, 2023

Hi @michikrug - I accidentally found this PR, when looking for support for action.devices.types.AC_UNIT.
Do you still plan to pursue these changes?

@michikrug
Copy link
Collaborator Author

Hi @michikrug - I accidentally found this PR, when looking for support for action.devices.types.AC_UNIT. Do you still plan to pursue these changes?

Yes, I do. I need to sort some things out and try to move on here in the next weeks.

@michikrug
Copy link
Collaborator Author

As I am running those changes for months already in my setup, I feel pretty confident.
I still want to make an official announcement in the openHAB community forum so that people will be aware of those breaking changes.

Signed-off-by: Michael Krug <michi.krug@gmail.com>
Signed-off-by: Michael Krug <michi.krug@gmail.com>
Signed-off-by: Michael Krug <michi.krug@gmail.com>
Signed-off-by: Michael Krug <michi.krug@gmail.com>
Signed-off-by: Michael Krug <michi.krug@gmail.com>
Signed-off-by: Michael Krug <michi.krug@gmail.com>
Signed-off-by: Michael Krug <michi.krug@gmail.com>
Signed-off-by: Michael Krug <michi.krug@gmail.com>
Signed-off-by: Michael Krug <michi.krug@gmail.com>
Signed-off-by: Michael Krug <michi.krug@gmail.com>
@michikrug
Copy link
Collaborator Author

Sorry for the delay here. Currently being busy with work and private stuff.
Also trying to update my own setup to OH4, which needs a dist upgrade on my PI...

Signed-off-by: Michael Krug <michi.krug@gmail.com>
@Kardiii
Copy link

Kardiii commented May 14, 2024

Hello @michikrug @marziman,

Sorry for tagging you :)

What is the state of this PR? I'm really looking forward to be able to use GA to control AC added in OH natively.
Since February was quite a while i'd like to see when it would be possible to have this feature in Openhab.

@michikrug
Copy link
Collaborator Author

I am super sorry.
I completely lost track of following up the release of this during the last months.

In general it is ready to go for quite some while already.
Due to some breaking changes and time to adjust on the users' side, a slow rollout was planned... but not as slow as it happened now 😁

I will make another announcement in the community forum in the next days to release this as soon as possible. With hopefully no friction.

Fingers crossed.

Signed-off-by: Michael Krug <michi.krug@gmail.com>
@michikrug
Copy link
Collaborator Author

Release scheduled for May 31st, 9PM CEST
https://community.openhab.org/t/openhab-google-assistant-v4-release-scheduled/156228

Signed-off-by: Michael Krug <michi.krug@gmail.com>
Signed-off-by: Michael Krug <michi.krug@gmail.com>
Signed-off-by: Michael Krug <michi.krug@gmail.com>
@michikrug michikrug merged commit 41ff357 into openhab:main May 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants