New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework device matching - Store members in customData #222

Closed

michikrug wants to merge 1 commit into openhab:main from michikrug:device-matching-rework

Collaborator

michikrug commented Jun 7, 2021 •

edited

Changes:

item names for group members are stored in customData to save a query request to openHAB when executing commands
for commands that need the current state the query request is still needed (thermostat commands or relative volume)
also some other configuration options are stored in customData
there is no change on the user's side required but they will need to do a SYNC

Possible issues:

As customData is limited to 512 bytes it could be an issue to store very long item names e.g. for devices with a lot of members like thermostat (ref. https://developers.google.com/assistant/smarthome/reference/intent/sync)


          Rework device matching, Store members in customData

92cf615

Signed-off-by: Michael Krug <michi.krug@gmail.com>

michikrug mentioned this pull request

Add advanced Fan capabilities #221

Closed

michikrug added enhancement work in progress labels

michikrug mentioned this pull request

Rework device matching | Store members in customData | Add AC Unit & Extended Fan #405

Merged

Collaborator Author

michikrug commented May 31, 2024

Superseded by #405

michikrug closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment