Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make openbabel objects thread-safe #2273

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Commits on Aug 23, 2020

  1. Make OBConversion operations thread-safe

    Major changes:
    
    - Global ttab object is now thread-safe
    - All related descriptions are now static
    - Add OBTranslator object for translating operations
    
    Minor changes:
    
    - Remove unused variables
    - Address some memory-related issues
    
    TODO:
    
    - member variable names are not consistent
    - PatternFP descriptions are not the same as before
    
    This resolves openbabel#2269.
    jnooree committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    17e56d0 View commit details
    Browse the repository at this point in the history
  2. Implement thread-safe OBGlobalDataBase objects

    Major Changes:
    
    - Add OBResidueObserver class for residue operations
    - Change global static mutexes into protected class member variables
    - Add OBGlobalDBMutex class to address copyability issue
    jnooree committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    a02668f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    277cf2d View commit details
    Browse the repository at this point in the history
  4. Remove unused variables

    jnooree committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    7bd2ad0 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. Add concurrency

    - OBMol, OBBase, and OBError classes are partially thread-safe
    - Fix a static function-local variable in OBConversion to thread_local static variable
    jnooree committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    3603865 View commit details
    Browse the repository at this point in the history
  2. Fix build

    jnooree committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    339d63c View commit details
    Browse the repository at this point in the history
  3. Fix MSVC build error

    jnooree committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    deccb54 View commit details
    Browse the repository at this point in the history