Make openbabel objects thread-safe #2273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major changes: - Global ttab object is now thread-safe - All related descriptions are now static - Add OBTranslator object for translating operations Minor changes: - Remove unused variables - Address some memory-related issues TODO: - member variable names are not consistent - PatternFP descriptions are not the same as before This resolves openbabel#2269.
Major Changes: - Add OBResidueObserver class for residue operations - Change global static mutexes into protected class member variables - Add OBGlobalDBMutex class to address copyability issue
- OBMol, OBBase, and OBError classes are partially thread-safe - Fix a static function-local variable in OBConversion to thread_local static variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this pull request make only some of the openbabel objects thread-safe:
OpenBabel::OBConversionandOpenBabel::OBGlobalDataBase. I will keep working on this topic for the rest of the objects and update this PR.Important note: this commit will change the API of openbabel.