Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #16235: need quote fullyQualifiedName in Ingestion Framework #16236

Closed
wants to merge 4 commits into from

Conversation

juntaozhang
Copy link
Contributor

Describe your changes:

Fixes #16235

  • in def get_latest_table_profile, the arg of quote about safe should remove /
  • in web_analytic_report_data_processor.py, entity_href parse need quote full url because of special characters like dim(shop)

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes #16235: need quote fullyQualifiedName in Ingestion Framework
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@juntaozhang juntaozhang requested a review from a team as a code owner May 13, 2024 10:44
Copy link

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link

sonarcloud bot commented May 14, 2024

@pmbrull
Copy link
Collaborator

pmbrull commented May 15, 2024

hi @juntaozhang , thanks for the PR. Pinged you on Slack as well. I'll be closing this in favor of a PR to main, which will ensure the fix is there for further versions too.

Thanks

@pmbrull pmbrull closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants