Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weird characters in fullyQualifiedName like dim(shop) or dim.api/client without quote will cause API call issue #16235

Closed
juntaozhang opened this issue May 13, 2024 · 1 comment · Fixed by #16273
Closed

weird characters in fullyQualifiedName like dim(shop) or dim.api/client without quote will cause API call issue #16235

juntaozhang opened this issue May 13, 2024 · 1 comment · Fixed by #16273

Comments

@juntaozhang
Copy link
Contributor

juntaozhang commented May 13, 2024 •
edited

Affected module
Ingestion Framework

Describe the bug
fullyQualifiedName contains special characters such as dim(shop) or dim.api/client, and there is no quote mark, which may cause api call issues.

To Reproduce
first ingest sample data : metadata ingest -c ./pipelines/sample_data.json
then execute DataInsightWorkflow like data-insights/airflow-sdk

Screenshots or steps to reproduce
weird characters in the sample data of shopify, when run DataInsightWorkflow will cause backend call issue.

for example:
image

Version:

  • OS: Macos
  • Python version:3.10.14
  • OpenMetadata version: [e.g. 0.8] 1.3.1
  • OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion==1.3.1.1]

Additional context
need quote fullyQualifiedName before API get request.
@juntaozhang juntaozhang mentioned this issue May 13, 2024
Closed
9 tasks
@juntaozhang
Copy link
Contributor Author

create PR for this issue: #16236

juntaozhang added a commit to juntaozhang/OpenMetadata that referenced this issue May 15, 2024
@juntaozhang
Fixes open-metadata#16235: need quote fullyQualifiedName in Ingestion…
015a7b8 
… Framework
@juntaozhang juntaozhang mentioned this issue May 15, 2024
Merged
9 tasks
TeddyCr pushed a commit that referenced this issue May 23, 2024
@juntaozhang
Fixes #16235: need quote fullyQualifiedName in Ingestion Framework (#…
8dd613c 
…16273)

* Fixes #16235: need quote fullyQualifiedName in Ingestion Framework

* MINOR: fix UT issue

* revert: fix UT issue

* revert code

* revert code

* format code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #16235: need quote fullyQualifiedName in Ingestion Framework juntaozhang/OpenMetadata
2 participants
@harshach @juntaozhang