Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate coveralls #1571

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .coveralls.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
service_name: travis-ci
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ group :test do

# Code Coverage Analysis
gem 'simplecov', '~> 0.12.0', require: false
gem 'coveralls', '~> 0.8.15', require: false

# So we can validate against json-schemas
gem 'json-schema', '~> 2.6.0'
Expand Down
15 changes: 11 additions & 4 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ GEM
sshkit (>= 1.6.1, != 1.7.0)
ansi (1.5.0)
arel (3.0.3)
autoprefixer-rails (6.3.7)
autoprefixer-rails (6.4.0.1)
execjs
awesome_print (1.6.1)
bcrypt (3.1.11)
Expand Down Expand Up @@ -179,6 +179,12 @@ GEM
sass (>= 3.2, < 3.5)
concurrent-ruby (1.0.2)
connection_pool (2.2.0)
coveralls (0.8.15)
json (>= 1.8, < 3)
simplecov (~> 0.12.0)
term-ansicolor (~> 1.3)
thor (~> 0.19.1)
tins (>= 1.6.0, < 2)
crack (0.4.3)
safe_yaml (~> 1.0.0)
cucumber (1.3.20)
Expand All @@ -187,12 +193,12 @@ GEM
gherkin (~> 2.12)
multi_json (>= 1.7.5, < 2.0)
multi_test (>= 0.1.2)
cucumber-rails (1.4.3)
cucumber-rails (1.4.4)
capybara (>= 1.1.2, < 3)
cucumber (>= 1.3.8, < 3)
mime-types (>= 1.16, < 4)
nokogiri (~> 1.5)
railties (>= 3, < 5)
railties (>= 3, < 5.1)
d3_rails (4.1.1)
railties (>= 3.1.0)
dagnabit (3.0.1)
Expand Down Expand Up @@ -563,7 +569,7 @@ GEM
tilt (1.4.1)
timers (4.1.1)
hitimes
tins (1.11.0)
tins (1.12.0)
treetop (1.4.15)
polyglot
polyglot (>= 0.3.1)
Expand Down Expand Up @@ -611,6 +617,7 @@ DEPENDENCIES
codemirror-rails!
coffee-rails (~> 3.2.2)
compass (~> 1.0.3)
coveralls (~> 0.8.15)
cucumber (~> 1.3)
cucumber-rails (~> 1.4.2)
d3_rails (~> 4.1.1)
Expand Down
5 changes: 4 additions & 1 deletion Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
# Add your own tasks in files placed in lib/tasks ending in .rake,
# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.

require 'coveralls/rake/task'
Coveralls::RakeTask.new

require File.expand_path('../lib/rake/task.rb', __FILE__)
require File.expand_path('../config/application', __FILE__)

Expand All @@ -28,4 +31,4 @@ Rake::Task['default'].prerequisites.delete('cucumber')
Rake::Task['default'].enhance([:'test:abort_if_elasticsearch_is_not_running'])
Rake::Task['default'].enhance([:'test:enable_coverage'])
Rake::Task['default'].enhance([:'test:freshen_fixtures'])
task :default => [:spec, :cucumber]
task :default => [:spec, :cucumber, 'coveralls:push']
3 changes: 3 additions & 0 deletions features/support/env.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
# instead of editing this one. Cucumber will automatically load all features/**/*.rb
# files.
require 'simplecov'
require 'coveralls'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No thanks. You should stop suggesting this as soon as #1570 gets merged.

Coveralls.wear_merged!('rails')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No thanks. You should stop suggesting this as soon as #1570 gets merged.


require 'sidekiq/testing'
require 'cucumber/rails'
require 'capybara/poltergeist'
Expand Down
3 changes: 3 additions & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
ENV["RAILS_ENV"] ||= 'test'

require 'simplecov'
require 'coveralls'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No thanks. You should stop suggesting this as soon as #1570 gets merged.

Coveralls.wear_merged!('rails')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No thanks. You should stop suggesting this as soon as #1570 gets merged.


require File.expand_path("../../config/environment", __FILE__)
require File.expand_path("../hets_helper", __FILE__)
require 'rspec/rails'
Expand Down