Reactivate coveralls #1571
Reactivate coveralls #1571
Conversation
| @@ -2,6 +2,9 @@ | |||
| ENV["RAILS_ENV"] ||= 'test' | |||
|
|
|||
| require 'simplecov' | |||
| require 'coveralls' | |||
| Coveralls.wear_merged!('rails') | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
There was a problem hiding this comment.
No thanks. You should stop suggesting this as soon as #1570 gets merged.
|
Okay, it seems like this needs to be stalled until we upgrade rails to version 4. |
eugenk
force-pushed
the
reactivate_coveralls
branch
from
ceefc4e
to
0a0bdfe
Compare
| config.x_frame_options = 'DENY' | ||
| config.x_content_type_options = "nosniff" | ||
| config.x_xss_protection = {:value => 1, :mode => false} | ||
| config.x_xss_protection = 'value=1; mode=false' |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
There was a problem hiding this comment.
No thanks. You should stop suggesting this as soon as #1570 gets merged.
|
It seems like we can do this anyway. The error (not visible here any more) was caused by the gem |
eugenk
force-pushed
the
reactivate_coveralls
branch
from
0a0bdfe
to
11fe80c
Compare
| config.x_content_type_options = "nosniff" | ||
| config.x_xss_protection = {:value => 1, :mode => false} | ||
| config.x_content_type_options = 'nosniff' | ||
| config.x_xss_protection = 'value=1; mode=false' |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
There was a problem hiding this comment.
No thanks. You should stop suggesting this as soon as #1570 gets merged.
eugenk
force-pushed
the
reactivate_coveralls
branch
4 times, most recently
from
0b992eb
to
81e052e
Compare
eugenk
force-pushed
the
reactivate_coveralls
branch
2 times, most recently
from
d0884d2
to
2fab6fc
Compare
|
I rebased this on staging. |
|
For an unknown reason, blank lines and lines only containing |
|
This seems to be an error in |
|
Yes, let's wait for simplecov-ruby/simplecov#444 and then update the gem. |
|
We will get back as soon as there is a new release of |
|
We have |
eugenk
force-pushed
the
reactivate_coveralls
branch
from
2fab6fc
to
09f3de8
Compare
eugenk
force-pushed
the
reactivate_coveralls
branch
from
09f3de8
to
0ef6a45
Compare
|
Changes Unknown when pulling 0ef6a45 on reactivate_coveralls into * on staging*. |
This is supposed to reactivate coveralls notifications in pull requests.
The branch of this pull request is not based on staging, but on the one of #1572 (update_gems). Reviewing that one first may be easier.The first commit of this branch isAdd coveralls gem (and resolve dependencies). 30abe0d