Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional first arg for Vector.record can be an ARTIFICIAL_CELL #2858

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Optional first arg for Vector.record can be an ARTIFICIAL_CELL #2858

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0041a06
Optional first arg for Vector.record can be an ARTIFICIAL_CELL
nrnhines Apr 25, 2024
e10de94
Merge branch 'master' into hines/record-artcell
pramodk May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/nrniv/vrecord.cpp
View file
Open in desktop
Expand Up @@ -38,8 +38,8 @@
if (hoc_is_object_arg(1)) {
iarg = 1;
ppobj = *hoc_objgetarg(1);
if (!ppobj || ppobj->ctemplate->is_point_ <= 0 ||
nrn_is_artificial_[ob2pntproc(ppobj)->prop->_type]) {
if (!ppobj || (ppobj->ctemplate->is_point_ <= 0 &&
!nrn_is_artificial_[ob2pntproc(ppobj)->prop->_type])) {

Check warning on line 42 in src/nrniv/vrecord.cpp

View check run for this annotation

Codecov / codecov/patch

src/nrniv/vrecord.cpp#L42 

Added line #L42 was not covered by tests
hoc_execerror("Optional first arg is not a POINT_PROCESS", 0);
}
}
Expand Down