Optional first arg for Vector.record can be an ARTIFICIAL_CELL #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ 0041a06 -> Azure artifacts URL |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2858 +/- ##
==========================================
+ Coverage 67.18% 67.19% +0.01%
==========================================
Files 563 563
Lines 104284 104279 -5
==========================================
+ Hits 70064 70074 +10
+ Misses 34220 34205 -15 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
|
The CI was previously green here. I have re-launched CI on this branch just to see if the issue with recent latest failures is code related or runners environment. cc: @alkino |
|
|
✔️ e10de94 -> Azure artifacts URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing logic of the
ifstatement that generated the error message"Optional first arg is not a POINT_PROCESS"was incorrect.[ ] add test
[ ] update documentation
The Vector.record also presently requires the existence of a Section. This seems unnecessary if the POINT_PROCESS or ARTIFICIAL_CELL arg is present. Section could disagree with POINT_PROCESS about which thread they are in.
It is not easy for the user to determine the thread of an ARTIFICIAL_CELL. Perhaps there should be a method for ARTIFICIAL_CELL and POINT_PROCESS which returns the thread id. Also, recording thread time and associating with a range variable is not obvious to the user. Finally, Vector.record(callable) could be useful.