Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build modlunit/nocmodl with their own CMakeLists.txt #2848

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Build modlunit/nocmodl with their own CMakeLists.txt #2848

wants to merge 24 commits into from

Conversation

alkino
Copy link
Member

@alkino alkino commented Apr 22, 2024 •
edited

  • Create a CMakeLists.txt for nocmodl
  • Create a CMakeLists.txt for modlunit
  • Create a CMakeLists.txt for nrnoc
  • Simplify nocmodl_mod_to_cpp cmake macro
  • Move wrap_sprintf to utils
  • Remove code related to NRN_COVERAGE_LIB because it has been make empty since a long time.
  • Use flex_target and bison_target instead of our own cmake macros and functions.

New targets:

  • modlunit: an executable to <??>
  • nocmodl: a compiler for mod files
  • default_mods: to create a static library of default compiled mod files

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ 084effa -> Azure artifacts URL

@alkino alkino changed the title Build modlunit with its own CMakeLists.txt Build modlunit/nocmodl with its own CMakeLists.txt Apr 22, 2024
@alkino alkino changed the title Build modlunit/nocmodl with its own CMakeLists.txt Build modlunit/nocmodl with their own CMakeLists.txt Apr 22, 2024
@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ 9a01585 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
nrnhines
nrnhines reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the main purpose of this refactoring to pave the way for future replacment of nocmodl with the new NMODL?

cmake/MacroHelper.cmake Outdated Show resolved Hide resolved
cmake/MacroHelper.cmake Outdated Show resolved Hide resolved
@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ 7968d7c -> Azure artifacts URL

@alkino
Copy link
Member Author

alkino commented Apr 23, 2024

Is the main purpose of this refactoring to pave the way for future replacment of nocmodl with the new NMODL?

Yes, and to continue to clean the build process of nrn by separating what should be split.

Base automatically changed from cornu/configure_file_is_better to master April 24, 2024 15:48
@alkino alkino closed this Apr 24, 2024
@alkino alkino reopened this Apr 24, 2024
@azure-pipelines Azure Pipelines
Copy link

✔️ 98fca63 -> Azure artifacts URL

@codecov Codecov
Copy link

codecov bot commented Apr 24, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.04%. Comparing base (d99cbb5) to head (0e91489).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2848      +/-   ##
==========================================
- Coverage   67.18%   66.04%   -1.14%     
==========================================
  Files         564      530      -34     
  Lines      104268    96000    -8268     
==========================================
- Hits        70053    63405    -6648     
+ Misses      34215    32595    -1620

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@alkino alkino marked this pull request as ready for review April 25, 2024 11:27
@azure-pipelines Azure Pipelines
Copy link

✔️ 65550e9 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines Azure Pipelines
Copy link

✔️ f97c78a -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
1uc
1uc previously approved these changes May 6, 2024
View reviewed changes
@1uc 1uc dismissed their stale review May 6, 2024 09:51

mistakenly approved

@azure-pipelines Azure Pipelines
Copy link

✔️ 61b317e -> Azure artifacts URL

@azure-pipelines Azure Pipelines
Copy link

✔️ df9746f -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@azure-pipelines Azure Pipelines
Copy link

✔️ 0e91489 -> Azure artifacts URL

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #209930 (:white_check_mark:) have been uploaded here!

Status and direct links:

@alkino alkino mentioned this pull request May 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrnhines nrnhines nrnhines left review comments

@1uc 1uc 1uc left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alkino @bbpbuildbot @nrnhines @1uc