Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify computation of neuronhome paths #2874

Merged
merged 3 commits into from May 10, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented May 8, 2024

Needed for #2848 and still nice to have

src/modlunit/units.cpp Outdated Show resolved Hide resolved
Copy link

✔️ 85f602d -> Azure artifacts URL

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.20%. Comparing base (4a1e15a) to head (1082c4b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2874   +/-   ##
=======================================
  Coverage   67.20%   67.20%           
=======================================
  Files         563      563           
  Lines      104247   104253    +6     
=======================================
+ Hits        70058    70065    +7     
+ Misses      34189    34188    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

src/modlunit/units.cpp Outdated Show resolved Hide resolved
Nicolas Cornu added 2 commits May 10, 2024 10:40
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

✔️ 1082c4b -> Azure artifacts URL

Copy link
Contributor

@JCGoran JCGoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor comments, LGTM.

@alkino alkino merged commit 0e781ec into master May 10, 2024
37 checks passed
@alkino alkino deleted the cornu/simplify_windows_unix_path branch May 10, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants