Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: add config to control whether to init public role permissions #33165

Merged
merged 1 commit into from
May 21, 2024
Merged

enhance: add config to control whether to init public role permissions #33165

merged 1 commit into from
May 21, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented May 20, 2024

issue: #33164

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label May 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 20, 2024
@SimFG SimFG mentioned this pull request May 20, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented May 20, 2024 •
edited

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.17%. Comparing base (89ad3eb) to head (e0c0d35).
Report is 15 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33165      +/-   ##
==========================================
+ Coverage   82.15%   82.17%   +0.01%     
==========================================
  Files        1009     1009              
  Lines      128824   128836      +12     
==========================================
+ Hits       105836   105868      +32     
+ Misses      18983    18970      -13     
+ Partials     4005     3998       -7
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.49% <100.00%> (+<0.01%) ⬆️
internal/rootcoord/root_coord.go 91.96% <77.77%> (+0.02%) ⬆️

... and 35 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels May 21, 2024
@mergify mergify bot added the ci-passed label May 21, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e18d5ac into milvus-io:master May 21, 2024
15 checks passed
sre-ci-robot pushed a commit that referenced this pull request May 21, 2024
@SimFG
enhance: [2.4] add config to control whether to init public role perm…
2a38f5b 
…issions (#33174)

issue: #33164
pr: #33165

Signed-off-by: SimFG <bang.fu@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@xiaofan-luan xiaofan-luan

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SimFG @xiaofan-luan @sre-ci-robot